Re: [PATCH v3 28/38] drm/msm/dp: add dp_mst_drm to manage DP MST bridge operations

[Dmitry Baryshkov]

On Tue, Apr 07, 2026 at 03:42:34PM +0800, Yongxing Mou wrote:
> 
> 
> On 8/27/2025 1:36 AM, Dmitry Baryshkov wrote:
> > On Mon, Aug 25, 2025 at 10:16:14PM +0800, Yongxing Mou wrote:
> > > +	struct msm_dp_panel *msm_dp_panel;
> > > +};
> > > +
> > > +struct msm_dp_mst_bridge_state {
> > > +	struct drm_private_state base;
> > > +	struct drm_connector *connector;
> > > +	struct msm_dp_panel *msm_dp_panel;
> > > +
> > > +	int vcpi;
> > > +	int pbn;
> > > +	int num_slots;
> > > +	int start_slot;
> > 
> > I'd definitely prefer to have payload pointer here, if that's also a
> > part of the state.
> > 
> Here if we not need pbn/vcpi/slots/start_slot in bridge state, can we delete
> whole bridge state and move connector/dp_panel to bridge?

Where is dp_panel identified / assigned? If it is not atomic_check(),
then you can move it away from the bridge state. The same applied to
connector.


-- 
With best wishes
Dmitry