Re: [PATCH] Documentation: sysctl: document net core sysctls

[Jonathan Corbet]

Shubham Chakraborty <chakrabortyshubham66@xxxxxxxxx> writes:

Thanks for working to make our documentation better.  A few notes,
though...

This is a networking-related patch, so it really needs to go to the
networking maintainers.

> Document missing net.core and net.unix sysctl entries in admin-guide/sysctl/net.rst, and correct wording for defaults that are derived from PAGE_SIZE, HZ, or CONFIG_MAX_SKB_FRAGS.
>
> Also clarify that the RFS and flow-limit controls are only present when CONFIG_RPS or CONFIG_NET_FLOW_LIMIT is enabled, and describe rps_sock_flow_entries the way the handler implements it: non-zero values are rounded up to the nearest power of two.

Please word-wrap your changelog text.

> Validation: git diff --check -- Documentation/admin-guide/sysctl/net.rst
> Validation: make -j1 O=/tmp/linux-docs-check SPHINXDIRS=admin-guide/sysctl htmldocs

This isn't a recognized tag, so shouldn't be expressed this way.  If you
want, you can describe your testing setup after the "---" line.

> Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@xxxxxxxxx>
> ---
>  Documentation/admin-guide/sysctl/net.rst | 66 +++++++++++++++++++++++-
>  1 file changed, 64 insertions(+), 2 deletions(-)

The actual changes are best reviewed by the networking developers.

Thanks,

jon