Re: [PATCH 2/2] staging: sm750fb: propagate error codes from de_wait()

From: Greg Kroah-Hartman

Date: Thu Apr 09 2026 - 11:27:38 EST


On Thu, Apr 09, 2026 at 08:15:36AM -0700, Denny Lin wrote:
> Hi Greg,
>

Odd email style, try replying inline in the real email, not at the top
please :)

> > Why did you delete the comment?
>
> The comment was removed as part of simplifying the code while
> changing the error handling to propagate the return value from
> de_wait(). I can restore or update it if needed.

Please keep it.

> > And when did de_wait() start returning correct values?
>
> de_wait() starts returning a proper errno value in patch 1 of this
> series, where the timeout return value is changed from -1 to
> -ETIMEDOUT. This patch then propagates that error value.

Ah, that wasn't obvious, sorry.

thanks,

greg k-h