Re: [PATCH v2] iio: frequency: ad983x: replace do_div() with div64_ul().
From: Andy Shevchenko
Date: Thu Apr 09 2026 - 11:59:16 EST
On Thu, Apr 09, 2026 at 10:39:07AM -0500, David Lechner wrote:
> On 4/9/26 10:01 AM, Joshua Crofts wrote:
> > Coccinelle reported the following in both ad983x drivers:
> > do_div() does a 64-by-32 division, please consider using
> > div64_ul instead.
> >
> > Fix this by replacing do_div() with div64_ul(), which
> > safely handles 64-bit dividends and unsigned long
> > divisors across all architectures.
> >
> > Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> > ---
> > v2:
>
> Please don't send v2 or later revisions in reply to v1. It breaks
> some workflows. Start a new thread instead.
> > - resent email with corrected addresses
>
> Instead of a v2, you can just add a RESEND prefix to the subject line
> in cases like this. But do include an explanation like this when you
> do that.
Nevertheless my comments still applicable to v2. The also Documented
recommendation to avoid sending new versions earlier than 24h.
--
With Best Regards,
Andy Shevchenko