Re: [PATCH] mips: mm: Call rcutree_report_cpu_starting() even earlier
From: Stefan Wiehler
Date: Thu Apr 09 2026 - 12:40:10 EST
> You could use `use_slab' to figure out whether it is a secondary CPU, but
> the right fix AFAICT is to reorder the `rcutree_report_cpu_starting' ahead
> of `per_cpu_trap_init' in `start_secondary', possibly even to the start of
> the function (does it rely on any of the initialisation done earlier on?).
Thanks, reordering the rcutree_report_cpu_starting() call in start_secondary()
is indeed much better; funny that I forgot my own change in commit 55702ec9603e
("mips/smp: Call rcutree_report_cpu_starting() earlier") from some years ago.
Will sent out a v2 shortly.
> NB is `rcu_cpu_starting' the right function call to make, and where does
> `cpu' come from here?
Sorry, rcu_cpu_starting() has been renamed to rcutree_report_cpu_starting() at
some point, and I accidentally sent out the patch for our LTS kernel; also
fixed in v2.
Kind regards,
Stefan