Re: [RFC V1 12/16] arm64/mm: Abstract printing of pxd_val()

[Anshuman Khandual]

On 08/04/26 5:58 PM, David Hildenbrand (Arm) wrote:
> On 2/24/26 06:11, Anshuman Khandual wrote:
> 
> Subject: you probably mean "pxx_val()" ?

Yes - sounds better will change.

> 
>> Ahead of adding support for D128 pgtables, refactor places that print
>> PTE values to use the new __PRIpte format specifier and __PRIpte_args()
>> macro to prepare the argument(s). When using D128 pgtables in future,
>> we can simply redefine __PRIpte and __PTIpte_args().
>>
>> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
>> Cc: Will Deacon <will@xxxxxxxxxx>
>> Cc: Ryan Roberts <ryan.roberts@xxxxxxx>
>> Cc: Mark Rutland <mark.rutland@xxxxxxx>
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
>> ---
>>  arch/arm64/include/asm/pgtable-types.h |  3 +++
>>  arch/arm64/include/asm/pgtable.h       | 22 +++++++++++-----------
>>  arch/arm64/mm/fault.c                  | 10 +++++-----
>>  3 files changed, 19 insertions(+), 16 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/pgtable-types.h b/arch/arm64/include/asm/pgtable-types.h
>> index 265e8301d7ba..dc3791dc9f14 100644
>> --- a/arch/arm64/include/asm/pgtable-types.h
>> +++ b/arch/arm64/include/asm/pgtable-types.h
>> @@ -11,6 +11,9 @@
>>  
>>  #include <asm/types.h>
>>  
>> +#define __PRIpte		"016llx"
>> +#define __PRIpte_args(val)	((u64)val)
> 
> Same comment regarding "pte" being misleading.

Sure - will rename __PRIpte as PRIpxx instead.

> 
>