Re: [PATCH v4 01/11] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk

[Kuldeep Singh]

On 4/7/2026 10:28 AM, Kuldeep Singh wrote:
>>> Hi Krzysztof,
>>>
>>> As motive here is to enforce 2 clocks for upcoming targets and keep
>>> minItems as 1 for already merged ones for ensuring backward
>>> compatibility. Can we do like below?
>>>
>>> allOf:
>>>   - if:
>>>       not:
>>>         properties:
>>>           compatible:
>>>             contains:
>>>               enum:
>>>                 - qcom,kaanapali-inline-crypto-engine
>>>                 - qcom,qcs8300-inline-crypto-engine
>>>                 - qcom,sa8775p-inline-crypto-engine
>>>                 - qcom,sc7180-inline-crypto-engine
>>>                 - qcom,sc7280-inline-crypto-engine
>>>                 - qcom,sm8450-inline-crypto-engine
>>>                 - qcom,sm8550-inline-crypto-engine
>>>                 - qcom,sm8650-inline-crypto-engine
>>>                 - qcom,sm8750-inline-crypto-engine
>>>
>>>     then:
>>>       required:
>>>         - power-domains
>>>         - clock-names
>>>       properties:
>>>         clocks:
>>>           minItems: 2
>>>         clock-names:
>>>           minItems: 2
>>>
>>> This will ensure for every new target addition, default clock count is
>>> enforced as 2 default.
>>> Please share your thoughts as well.
> 
> Hi Rob/Krzysztof,
> 
> Were you able to review this suggestion?
> Please let me know if need to update patch on top of this one to
> initiate discussion.
> 
> One advantage i see with suggested approach:
> For new target addition, just need to document new compatible string and
> no need to update another list everytime.
> It's easy to miss adding entry alongside eliza/milos and might make
> wrong assumption to authors/dt-checker that 1 clock is still allowed.
> 

Hi Krzysztof/Rob,
Kind reminder!
Could you please share your thoughts.

-- 
Regards
Kuldeep