Re: [PATCH v2 1/4] rust: netlink: add raw netlink abstraction

[Alice Ryhl]

On Thu, Apr 9, 2026 at 11:50 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > +__rust_helper void rust_helper_genlmsg_cancel(struct sk_buff *skb, void *hdr)
> > +{
> > +     return genlmsg_cancel(skb, hdr);
> > +}
> > +
> > +__rust_helper void rust_helper_genlmsg_end(struct sk_buff *skb, void *hdr)
> > +{
> > +     return genlmsg_end(skb, hdr);
> > +}
> > +
> > +__rust_helper void rust_helper_nlmsg_free(struct sk_buff *skb)
> > +{
> > +     return nlmsg_free(skb);
> > +}
>
> It is a bit odd for a void function to call return like this,
> especially when the functions they are calling are also void
> functions.

Oh you're right. I think that's what we call a copy-paste mistake.
I'll fix it up in the next version.

Alice