Re: [PATCH] HID: logitech-dj: fix wrong detection of bad DJ_SHORT output report

From: Jiri Kosina

Date: Fri Apr 10 2026 - 11:41:48 EST


On Fri, 10 Apr 2026, Benjamin Tissoires wrote:

> commit b6a57912854e ("HID: logitech-dj: Prevent REPORT_ID_DJ_SHORT
> related user initiated OOB write") assumed that all HID devices attached
> to the logitech-dj driver was having an output report of DJ_SHORT.
>
> However, on the receiver itself, we have 2 other HID device we attach
> here: the mouse emulation and the keyboard emulation. For those devices
> the value of rep is NULL and we are triggered a segfault here.
>
> This is doubly required because logitech-dj also handles non DJ devices
> that might not have the DJ collection.
>
> Fixes: b6a57912854e ("HID: logitech-dj: Prevent REPORT_ID_DJ_SHORT related user initiated OOB write")
> Signed-off-by: Benjamin Tissoires <bentiss@xxxxxxxxxx>

Thanks a lot Benjamin, your CI be praised!

Applied.

--
Jiri Kosina
SUSE Labs