Re: [PATCH v3 2/2] hwmon: (pmbus/q54sj108a2) Add support for q50sn12072 and q54sn120a1

[Guenter Roeck]

On 4/1/26 18:29, Brian Chiang wrote:
> From: Jack Cheng <cheng.jackhy@xxxxxxxxxxxx>
>
> The Q50SN12072 and Q54SN120A1 are high-efficiency, high-density DC-DC power
> module from Delta Power Modules.
>
> The Q50SN12072, quarter brick, single output 12V. This product provides up
> to 1200 watts of output power at 38~60V. The Q50SN12072 offers peak
> efficiency up to 98.3%@54Vin.
>
> The Q54SN120A1, quarter brick, single output 12V. This product provides up
> to 1300 watts of output power at 40~60V. The Q54SN120A1 offers peak
> efficiency up to 98.1%@54Vin.
>
> Add support for them to q54sj108a2 driver.
>
> Signed-off-by: Jack Cheng <cheng.jackhy@xxxxxxxxxxxx>
> Co-developed-by: Brian Chiang <chiang.brian@xxxxxxxxxxxx>
> Signed-off-by: Brian Chiang <chiang.brian@xxxxxxxxxxxx>
> ---
...
> -	/*
> -	 * The chips support reading PMBUS_MFR_MODEL.
> -	 */
>   	ret = i2c_smbus_read_block_data(client, PMBUS_MFR_MODEL, buf);
>   	if (ret < 0) {
>   		dev_err(dev, "Failed to read Manufacturer Model\n");
>   		return ret;
>   	}
> -	if (ret != 14 || strncmp(buf, "Q54SJ108A2", 10)) {
> +	for (mid = q54sj108a2_id; mid->name[0]; mid++) {
> +		if (!strncasecmp(mid->name, buf, strlen(mid->name)))
> +			break;
> +	}

If ret < strlen(mid->name), this check compares uninitialized data.
Also see Sashiko feedback:

https://sashiko.dev/#/patchset/20260402-add-support-for-q50sn12072-and-q54sn120a1-v3-0-67a5184e93b8%40inventec.com

Thanks,
Guenter