Re: [PATCH v5 0/3] hwmon: (sht3x) Add support for GXCAS GXHT30
From: Guenter Roeck
Date: Fri Apr 10 2026 - 13:05:41 EST
On 4/3/26 03:14, Zaixiang Xu wrote:
Hi all,
First, I sincerely apologize for the noise in v3 and v4. I unfortunately
missed the crucial feedback provided in v1 by Krzysztof, Conor,
and Guenter.
In this v5, I have completely dropped the incorrect approaches from the
previous versions and completely refactored the patchset to strictly
follow the maintainers' guidelines:
1. Wildcards are entirely avoided. Explicit chip names are used.
2. The standalone YAML binding has been dropped. The devices are
now added to trivial-devices.yaml.
3. The redundant of_match_table addition in the driver is dropped.
The driver now relies on the I2C core's fallback matching mechanism.
Patch 1 adds the vendor prefix for GXCAS (Carries Conor's Acked-by
from v1).
Patch 2 adds the explicit SHT3x/STS3x and GXHT30 models to
trivial-devices.yaml.
Patch 3 adds minimal I2C ID support to the sht3x driver.
Sashiko feedback:
https://sashiko.dev/#/patchset/1775211296-63722-1-git-send-email-zaixiang.xu.dev%40gmail.com
I think at the very least this will require a proper of_device_id table.
Thanks,
Guenter