Re: [PATCH] firmware: raspberrypi: Change dependency to ARCH_BCM2835 and COMPILE_TEST

[Florian Fainelli]

On 4/8/26 01:11, Chen-Yu Tsai wrote:
> The Raspberry Pi firmware driver has no compile dependencies on the
> BCM2835 mailbox driver. It's just a indirect runtime dependency: the
> driver only works on a Raspberry Pi.
>
> Change the dependency from BCM2835_MBOX to ARCH_BCM2835. Also allow
> compile tests. This allows drivers that have build time dependencies
> on this firmware driver to be compile tested as well.
>
> Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>

No objection, however I think this should also have:

	default ARCH_BRCM2835

because without the firmware driver there is effectively nothing that 
works. See this patch series:

https://lists.infradead.org/pipermail/linux-arm-kernel/2024-May/927679.html

> ---
>   drivers/firmware/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index bbd2155d8483..f99d27c1f6a4 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -114,7 +114,7 @@ config ISCSI_IBFT
>   
>   config RASPBERRYPI_FIRMWARE
>   	tristate "Raspberry Pi Firmware Driver"
> -	depends on BCM2835_MBOX
> +	depends on ARCH_BCM2835 || COMPILE_TEST
>   	help
>   	  This option enables support for communicating with the firmware on the
>   	  Raspberry Pi.


--
Florian