Re: [PATCH v1 1/5] dt-bindings: interrupt-controller: Convert the word "jh8100" to "jhb100"
From: Conor Dooley
Date: Fri Apr 10 2026 - 13:43:15 EST
On Fri, Apr 10, 2026 at 02:01:02AM -0700, Changhuang Liang wrote:
> The StarFive JH8100 SoC was discontinued before production. The
> newly taped-out JHB100 SoC uses the same interrupt controller IP.
>
> Rename the binding file, compatible string, and MAINTAINERS entry
> from "jh8100" to "jhb100". In JHB100 SoC, The clocks and resets are
> not operated by users, but they exist in the hardware. Mark them as
> optional.
Content looks fine, I think the commit message should be changed to
something like "repurpose binding for unreleased jh8100 for jhb100".
W/ something along those lines
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
pw-bot: not-applicable
>
> Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> ---
> ...ve,jh8100-intc.yaml => starfive,jhb100-intc.yaml} | 12 ++++--------
> MAINTAINERS | 2 +-
> 2 files changed, 5 insertions(+), 9 deletions(-)
> rename Documentation/devicetree/bindings/interrupt-controller/{starfive,jh8100-intc.yaml => starfive,jhb100-intc.yaml} (81%)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/starfive,jh8100-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/starfive,jhb100-intc.yaml
> similarity index 81%
> rename from Documentation/devicetree/bindings/interrupt-controller/starfive,jh8100-intc.yaml
> rename to Documentation/devicetree/bindings/interrupt-controller/starfive,jhb100-intc.yaml
> index ada5788602d6..576b1d6c7973 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/starfive,jh8100-intc.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/starfive,jhb100-intc.yaml
> @@ -1,13 +1,13 @@
> # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/interrupt-controller/starfive,jh8100-intc.yaml#
> +$id: http://devicetree.org/schemas/interrupt-controller/starfive,jhb100-intc.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: StarFive External Interrupt Controller
>
> description:
> - StarFive SoC JH8100 contain a external interrupt controller. It can be used
> + StarFive SoC JHB100 contain a external interrupt controller. It can be used
> to handle high-level input interrupt signals. It also send the output
> interrupt signal to RISC-V PLIC.
>
> @@ -16,7 +16,7 @@ maintainers:
>
> properties:
> compatible:
> - const: starfive,jh8100-intc
> + const: starfive,jhb100-intc
>
> reg:
> maxItems: 1
> @@ -40,8 +40,6 @@ properties:
> required:
> - compatible
> - reg
> - - clocks
> - - resets
> - interrupts
> - interrupt-controller
> - "#interrupt-cells"
> @@ -51,10 +49,8 @@ additionalProperties: false
> examples:
> - |
> interrupt-controller@12260000 {
> - compatible = "starfive,jh8100-intc";
> + compatible = "starfive,jhb100-intc";
> reg = <0x12260000 0x10000>;
> - clocks = <&syscrg_ne 76>;
> - resets = <&syscrg_ne 13>;
> interrupts = <45>;
> interrupt-controller;
> #interrupt-cells = <1>;
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d238590a31f2..a2961727e3d1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -25312,7 +25312,7 @@ F: drivers/phy/starfive/phy-jh7110-usb.c
> STARFIVE JH8100 EXTERNAL INTERRUPT CONTROLLER DRIVER
> M: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> S: Supported
> -F: Documentation/devicetree/bindings/interrupt-controller/starfive,jh8100-intc.yaml
> +F: Documentation/devicetree/bindings/interrupt-controller/starfive,jhb100-intc.yaml
> F: drivers/irqchip/irq-starfive-jh8100-intc.c
>
> STATIC BRANCH/CALL
> --
> 2.25.1
>
>
Attachment:
signature.asc
Description: PGP signature