Re: [PATCH v5 2/4] ASoC: codecs: Add TAS67524 quad-channel audio amplifier driver
From: Sen Wang
Date: Fri Apr 10 2026 - 13:57:05 EST
On 4/10/26 09:02, Mark Brown wrote:
On Thu, Apr 09, 2026 at 05:06:04PM -0500, Sen Wang wrote:Hi Mark, Thanks for the review!
The TAS675x (TAS6754, TAS67524) are quad-channel, digital-input
Class-D amplifiers with an integrated DSP, controlled over I2C.
They support I2S and TDM serial audio interfaces.
This looks mostly good, but one issue I see is that AFAICT we only stop
fault_check_work during runtime suspsend - if runtime PM is disabled, or
if the driver is removed, the work will be left running.
I neglected the driver removal part. I'll cancel check_work and remove IRQ in i2c_remove to prevent any possible use-after-free.
Regarding fault_check_work w/o runtime PM: the device has fault
conditions that fire regardless of stream state, so the work runs for the duration of the active power state (runtime PM) rather than stream state.
I could add a DAPM event fallback to gate the work when runtime PM is not defined, but that's more restrictive; it could miss faults outside of active playback, and adds complexity for what is a fairly niche configuration (optional check_work with runtime PM disabled).
Do you think the DAPM fallback would suffice, or is the current approach (poll until removal) acceptable given the hardware behavior? Any other suggestions would be greatly appreciated!
Best,
Sen Wang