Re: [GIT PULL] RISC-V SpacemiT Devicetrees for v7.1
From: Linus Walleij
Date: Fri Apr 10 2026 - 18:25:09 EST
Hi Yixun,
I looked into this pull request.
I'm sorry if I do stupid mistakes in handling it, I'm new to maintaining
the SoC tree. Bear with me.
On Fri, Apr 3, 2026 at 2:32 PM Yixun Lan <dlan@xxxxxxxxxx> wrote:
> Aurelien Jarno (7):
> riscv: dts: spacemit: drop incorrect pinctrl for combo PHY
(...)
> Yixun Lan (9):
> riscv: dts: spacemit: pcie: fix missing power regulator
[Fixes]
fatal: Not a valid object name linus/master
Commit: c68360c0d636 ("riscv: dts: spacemit: drop incorrect pinctrl
for combo PHY")
Fixes tag: Fixes: 0be016a4b5d1b9 ("riscv: dts: spacemit: PCIe and
PHY-related updates")
Has these problem(s):
- Inspect: Target SHA is not ancestor of Linus' master branch,
which means it is fixing commit in your branch
fatal: Not a valid object name linus/master
Commit: 8a9071299dec ("riscv: dts: spacemit: pcie: fix missing power regulator")
Fixes tag: Fixes: 0be016a4b5d1 ("riscv: dts: spacemit: PCIe and
PHY-related updates")
Has these problem(s):
- Inspect: Target SHA is not ancestor of Linus' master branch,
which means it is fixing commit in your branch
So this means you introduced bugs and fix them in the same pull request?
Why?
The practice is to squash such fixes into the offending patches when
presenting pull requests. But I went ahead anyway, trying to not be so
picky. (The commits are there, in your branch indeed.)
- Checked that it was in linux-next OK
- built DTBS OK
Pulled in, thanks.
Yours,
Linus Walleij