Re: [PATCH v2] selftests: mm: skip charge_reserved_hugetlb without killall

[SeongJae Park]

On Fri, 10 Apr 2026 12:41:39 +0800 Cao Ruichuang <create0818@xxxxxxx> wrote:

> charge_reserved_hugetlb.sh tears down background writers with
> killall from psmisc. Minimal Ubuntu images do not always provide
> that tool, so the selftest fails in cleanup for an environment reason
> rather than for the hugetlb behavior it is trying to cover.
> 
> Skip the test when killall is unavailable, similar to the existing
> root check, so these environments report the dependency clearly
> instead of failing the test.
> 
> Signed-off-by: Cao Ruichuang <create0818@xxxxxxx>

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>

> ---
> v2:
> - replace the PID tracking approach with a simple skip when killall is
>   unavailable
> - follow Mike Rapoport's review suggestion

I was actually thinking if PID tracking approach is better reading this
chagelog.  But simple skipping also makes sense to me.

Btw, adding a link to the previous version [1] would be nice.

[1] https://docs.kernel.org/process/submitting-patches.html#commentary


Thanks,
SJ

[...]