Re: [PATCH v4 12/14] mm/vmscan: remove sc->file_taken

[Barry Song]

On Tue, Apr 7, 2026 at 8:04 PM Kairui Song via B4 Relay
<devnull+kasong.tencent.com@xxxxxxxxxx> wrote:
>
> From: Kairui Song <kasong@xxxxxxxxxxx>
>
> No one is using it now, just remove it.
>
> Reviewed-by: Axel Rasmussen <axelrasmussen@xxxxxxxxxx>
> Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Kairui Song <kasong@xxxxxxxxxxx>

Can we squash this into patch 10/14, where the user of
file_taken is removed?
The same applies to patch 13 as well :-)

> ---
>  mm/vmscan.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 73b1aeb6c292..79e8a8e6555c 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -173,7 +173,6 @@ struct scan_control {
>                 unsigned int congested;
>                 unsigned int writeback;
>                 unsigned int immediate;
> -               unsigned int file_taken;
>                 unsigned int taken;
>         } nr;
>
> @@ -2040,8 +2039,6 @@ static unsigned long shrink_inactive_list(unsigned long nr_to_scan,
>         sc->nr.writeback += stat.nr_writeback;
>         sc->nr.immediate += stat.nr_immediate;
>         sc->nr.taken += nr_taken;
> -       if (file)
> -               sc->nr.file_taken += nr_taken;
>
>         trace_mm_vmscan_lru_shrink_inactive(pgdat->node_id,
>                         nr_scanned, nr_reclaimed, &stat, sc->priority, file);
>
> --
> 2.53.0
>
>