Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants

From: Dan Carpenter

Date: Sat Apr 11 2026 - 04:07:45 EST


On Sat, Apr 11, 2026 at 10:58:17AM +0530, Adith-Joshua wrote:
> Replace hardcoded magic numbers in rtl8723b_InitBeaconParameters()
> with descriptive macros to improve readability and maintainability.
>
> No functional changes.
>
> Signed-off-by: Adith-Joshua <adithalex29@xxxxxxxxx>
> ---

Where did you find these numbers? Presumably there is a spec
somewhere? What does BCNTCFG_CW mean? This really looks like an AI
patch...

regards,
dan carpenter