Re: [PATCH net-next 1/3] psp: add crypt-offset and spi-threshold get/set attributes

[Akhilesh Samineni]

On Sat, Apr 11, 2026 at 2:27 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Sat, 11 Apr 2026 01:06:06 +0530 Akhilesh Samineni wrote:
> > On Wed, Apr 8, 2026 at 6:34 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> > > On Tue, 07 Apr 2026 17:37:41 -0400 Willem de Bruijn wrote:
> > > > PSP defines a 6-bit field in 4 octet units. Does this need bounds checking?
> > >
> > > More fundamentally, were we to support this -- is it a device property
> > > or an assoc property?
> >
> > It's a device property. All associations under the device will share
> > the same crypt-offset.
>
> I don't think there's anything in the spec that says the crypto
> offset is device level.

Yes, the spec didn’t mention the device level. We currently chose the
per-device approach based on the hardware implementation.

> At the very least every L4 proto may want to have a different offset.
We agree that per-protocol granularity would be more flexible because
L4 protocol header sizes differ.

> We should probably hold off adding this until a real user appears.
Sure we will hold off this change till that time.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature