Re: [PATCH] char: ds1620: clean up system_rev declaration and logging.

[Greg KH]

On Sat, Apr 11, 2026 at 01:50:25PM +0530, Shyam Sunder Reddy Padira wrote:
> Remove the local extern declaration of system_rev and
> included <asm/system_info.h> to use the existing declaration.
> 
> Convert printk() calls to pr_err() and pr_info(),
> and fix other checkpatch.pl reported warnings and errors.
> 
> No functional changes intended.

Plaese do not do checkpatch cleanups outside of drivers/staging/ unless
the subsystem maintainer says it is ok to do that, or you are the
maintainer of the driver.

Also, checkpatch cleanups need to be "one patch per logical thing".

If you are looking to do basic "how to get involved" tasks, stick to
drivers/staging/ please, that is what it is there for.

thanks,

greg k-h