Re: [PATCH 01/35] dt-bindings: qcom,pdc: Tighten reg to single APSS DRV region
From: Dmitry Baryshkov
Date: Sat Apr 11 2026 - 10:32:32 EST
On Sat, Apr 11, 2026 at 12:10:38AM +0530, Mukesh Ojha wrote:
> The PDC has multiple DRV regions, each sized 0x10000, where each region
> serves a specific client in the system. Linux only needs access to the
Nit: there are other OS than Linux. Would you rather point out that
other DRV regions are to be used by ... what?
> APSS DRV region, so the reg property should describe exactly one DRV
> region of size 0x10000.
>
> The example was using 0x30000 (three DRV regions) which is incorrect.
> Fix it to use 0x10000 to match the single APSS DRV region that the
> driver actually maps, consistent with the DT fixes applied across all
> platforms in this series.
>
> Signed-off-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> index f9321366cae4..786709f2d13e 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
> @@ -96,7 +96,7 @@ examples:
>
> pdc: interrupt-controller@b220000 {
> compatible = "qcom,sdm845-pdc", "qcom,pdc";
> - reg = <0xb220000 0x30000>;
> + reg = <0xb220000 0x10000>;
> qcom,pdc-ranges = <0 512 94>, <94 641 15>, <115 662 7>;
> #interrupt-cells = <2>;
> interrupt-parent = <&intc>;
> --
> 2.53.0
>
--
With best wishes
Dmitry