Re: [PATCH] staging: media: atomisp: fix indentation to use tabs instead of spaces

[David Laight]

On Sat, 11 Apr 2026 13:51:35 +0300
Dan Carpenter <error27@xxxxxxxxx> wrote:

> On Fri, Apr 10, 2026 at 05:55:12PM -0700, Michael Ugrin wrote:
> > Fix whitespace issue where a continuation line used spaces
> > instead of tabs for indentation.
> > 
> > Signed-off-by: Michael Ugrin <mugrinphoto@xxxxxxxxx>
> > ---
> >  .../staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c  | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c b/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c
> > index b411ca2f415e0..966d4efb200c5 100644
> > --- a/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c
> > +++ b/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c
> > @@ -1257,7 +1257,7 @@ ia_css_debug_pipe_graph_dump_stage(
> >  					p--;
> >  				/* Last comma found, copy till that comma */
> >  				strscpy(enable_info1, ei,
> > -                                        p > sizeof(enable_info1) ? sizeof(enable_info1) : p);
> > +					p > sizeof(enable_info1) ? sizeof(enable_info1) : p);  
> 
> Better to use:
> 
> 	strscpy(enable_info1, ei, umin(p, sizeof(enable_info1)));
> 
> Same for the other strscpy() calls as well.

Or refactor that code so it doesn't use 600+ bytes of stack and
lots of scanning of long strings.

From a quick scan it seems to be generating a string of xxx,yyy, with the ','
replaced by '\n' to avoid anything longer than 25 characters and at most three lines.
I'm sure you could write and use a function that lets you have a lot of lines like:
	offset = add_flag(info, offset, bi->enable.reduced_pipe, "rp");

Oh, and none of your char_enable_info[] arrays are guaranteed to
be aligned either.
So all the snprint and strscpy calls into different buffers are pointless.

	David

> 
> regards,
> dan carpenter
> 
>