Re: [PATCH bpf-next v13 2/5] bpf: Pass bpf_verifier_env to JIT

From: Alexei Starovoitov

Date: Sat Apr 11 2026 - 13:12:41 EST


On Sat, Apr 11, 2026 at 7:43 AM <bot+bpf-ci@xxxxxxxxxx> wrote:
>
> > diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
> > index 3fa3c74869d0..bd96b3a01b99 100644
> > --- a/kernel/bpf/core.c
> > +++ b/kernel/bpf/core.c
>
> [ ... ]
>
> > @@ -2553,46 +2530,53 @@ static bool bpf_prog_select_interpreter(struct bpf_prog *fp)
> > return select_interpreter;
> > }
> >
> > -static struct bpf_prog *bpf_prog_jit_compile(struct bpf_prog *prog)
> > +static struct bpf_prog *bpf_prog_jit_compile(struct bpf_verifier_env *env, struct bpf_prog *prog)
> > {
> > #ifdef CONFIG_BPF_JIT
> > struct bpf_prog *orig_prog;
> > + struct bpf_insn_aux_data *orig_insn_aux;
> >
> > if (!bpf_prog_need_blind(prog))
> > - return bpf_int_jit_compile(prog);
> > + return bpf_int_jit_compile(env, prog);
> > +
> > + if (env) {
> > + /* If env is not NULL, we are called from the end of bpf_check(), at this
> > + * point, only insn_aux_data is used after failure, so it should be restored
> > + * on failure.
> > + */
>
> This isn't a bug, but this multi-line comment has text on the
> opening /* line. The BPF subsystem preferred style places /* on
> its own line:
>
> /*
> * If env is not NULL, we are called from ...
> */

AI is correct.

pw-bot: cr