Re: [PATCH v4 12/39] drm/msm/dp: separate dp_display_prepare() into its own API
From: Dmitry Baryshkov
Date: Sat Apr 11 2026 - 13:43:08 EST
On Fri, Apr 10, 2026 at 05:33:47PM +0800, Yongxing Mou wrote:
> From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
>
> For MST, the link setup should only be done once when multiple sinks are
> enabled, while stream setup may run multiple times for each sink. Split
> the link-related preparation out of msm_dp_display_atomic_enable() so it
> can be called separately before the per-stream enable path.
>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 16 +++++++++++-----
> drivers/gpu/drm/msm/dp/dp_display.h | 5 +++--
> drivers/gpu/drm/msm/dp/dp_drm.c | 6 ++++--
> 3 files changed, 18 insertions(+), 9 deletions(-)
>
In the hope that the atomic_prepare() function ends up being used as the
.atomic_prepare callback...
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
--
With best wishes
Dmitry