Re: [PATCH net] net: phy: qcom: at803x: Use the correct bit to disable extended next page

[Andrew Lunn]

> > Should we keep ADVERTISE_RESV?
> > 
> >   45.2.7.6 AN advertisement register
> > 
> >   If the Auto-Negotiation advertisement register (register 4) is
> >   present, (see 28.2.4.1.3), then this register is a copy of the
> >   Auto-Negotiation advertisement register (register 4). In this case,
> >   reads to the AN advertisement register (7.16) report the value of
> >   the Auto-Negotiation advertisement register (register 4); writes to
> >   the AN advertisement register (7.16) cause a write to occur to the
> >   Auto-Negotiation advertisement register.
> > 
> > So MDIO_MMD_AN:MDIO_AN_ADVERTISE is a straight copy of MII_ADVERTISE.
> > 
> >         ef4_mdio_write(efx, MDIO_MMD_AN, MDIO_AN_ADVERTISE, reg);
> >         ret = phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_ADVERTISE, adv);
> > 
> > So ADVERTISE_XNP is just as valid in the other two drivers using
> > ADVERTISE_RESV. I think we should change those as well to
> > ADVERTISE_XNP and remove ADVERTISE_RESV?
> > 
> > 	Andrew
> 
> I agree with that yes and I've considered converting these drivers once
> we have net merged into net-next should this patch be applied :)

Ah, sorry, missed the patch was targeting net. Please do submit a
cleanup for net-next later on.

> That said, ADVERTISE_RESV is in uapi, is it even possible to remove it ?

Good point. It probably does have to stay.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew