Re: [PATCH 10/16] clk: Add support for clock nexus dt bindings

[Stephen Boyd]

Quoting Miquel Raynal (2026-04-01 01:47:51)
> Hello Brian,
> 
> First, thanks for the whole review.
> 
> On 30/03/2026 at 11:16:44 -04, Brian Masney <bmasney@xxxxxxxxxx> wrote:
> >> -            ret = of_parse_phandle_with_args(np, "clocks", "#clock-cells",
> >> -                                             index, out_args);
> >> +            ret = of_parse_phandle_with_args_map(np, "clocks", "clock",
> >> +                                                 index, out_args);
> >
> > Before I left my Reviewed-by, I should have double checked Sashiko. It
> > has several questions about this patch. The first is:
> >
> >     Are there other places in the clock framework that need to transition to the
> >     new map API to ensure assigned clocks work?
> >     
> >     For instance, assigned-clocks and assigned-clock-parents are parsed in
> >     drivers/clk/clk-conf.c using of_parse_phandle_with_args(). If a device
> >     specifies an assigned clock that routes through a nexus node, will it fail
> >     to configure because the map is not traversed?
> 
> The goal of the nexus node is to isolate what is behind. Are
> assigned-clocks et al. supposed to traverse a nexus node? I am tempted
> to say "no", but I'm open to discussing this ofc.

Why would assigned-clocks not traverse the nexus node? If I'm a DT
author I would think any clock specifier should be routed properly
through the nexus node.