Re: [PATCH 11/12] ASoC: dt-bindings: google,sc7280-herobrine: Add Radxa Dragon Q6A sound card

[Xilin Wu]

On 4/8/2026 4:48 PM, Krzysztof Kozlowski wrote:
> On Tue, Apr 07, 2026 at 11:20:03PM +0800, Xilin Wu wrote:
> > The Radxa Dragon Q6A can boot in EL2, allowing the kernel to access the
> > LPASS hardware directly. Add the compatible for it to the bindings.
>
> You are not adding compatible for LPASS, but for the sound card. And
> since you mentioned it, what happens when you boot in EL1?
>
> You need to post bindings for both cases.
>
> Best regards,
> Krzysztof

Hi Krzysztof,

Thank you for the review. You are right that this patch adds a 
board-specific compatible for the sound card, not for the LPASS block 
itself.

For EL1, the default Dragon Q6A DTS already uses the generic
"qcom,qcs6490-rb3gen2-sndcard" compatible, and for the EL2 LPASS-CPU
variant I can also just keep using the generic
"google,sc7280-herobrine" compatible.

Would it be better if I simply drop this binding patch and keep both
cases on their existing generic compatibles instead of introducing
"radxa,dragon-q6a-sndcard"?

--
Best regards,
Xilin Wu <sophon@xxxxxxxxx>