Re: [PATCH 0/5] crypto: hisilicon - series of cleanups and format fixes for hisilicon driver
From: Herbert Xu
Date: Sun Apr 12 2026 - 04:51:45 EST
On Mon, Mar 30, 2026 at 02:25:26PM +0800, Chenghai Huang wrote:
> 1.Fixed a format string type mismatch issue identified through static
> analysis and code review, which could have caused display errors.
> 2.A const qualifier addition to improve type safety.
> 3.Removing unnecessary else statements after a return.
> 4.Removal of redundant variable initializations that are overwritten
> before their first use.
> 5.A cleanup of unused and non-public APIs to shrink the public interface
> and remove dead code.
>
> Chenghai Huang (4):
> crypto: hisilicon/qm - add const qualifier to info_name in struct
> qm_cmd_dump_item
> crypto: hisilicon/qm - remove else after return
> crypto: hisilicon/qm - drop redundant variable initialization
> crypto: hisilicon - remove unused and non-public APIs for qm and sec
>
> Zhushuai Yin (1):
> crypto: hisilicon - fix the format string type error
>
> drivers/crypto/hisilicon/debugfs.c | 22 +++++++++++-----------
> drivers/crypto/hisilicon/qm.c | 16 ++++++++--------
> drivers/crypto/hisilicon/sec2/sec.h | 2 --
> drivers/crypto/hisilicon/sec2/sec_main.c | 2 +-
> include/linux/hisi_acc_qm.h | 2 --
> 5 files changed, 20 insertions(+), 24 deletions(-)
>
> --
> 2.33.0
All applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt