Re: [PATCH v7 2/2] dt-bindings: embedded-controller: Add synology microp devices

From: Krzysztof Kozlowski

Date: Sun Apr 12 2026 - 09:23:32 EST


On 12/04/2026 15:21, Markus Probst wrote:
> On Sun, 2026-04-12 at 10:26 +0200, Krzysztof Kozlowski wrote:
>> On Sat, Apr 11, 2026 at 05:27:35PM +0200, Markus Probst wrote:
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - synology,ds923p-microp
>>> + - synology,ds918p-microp
>>> + - synology,ds214play-microp
>>> + - synology,ds225p-microp
>>> + - synology,ds425p-microp
>>> + - synology,ds710p-microp
>>> + - synology,ds1010p-microp
>>> + - synology,ds723p-microp
>>> + - synology,ds1522p-microp
>>> + - synology,rs422p-microp
>>> + - synology,ds725p-microp
>>> + - synology,ds118-microp
>>> + - synology,ds124-microp
>>> + - synology,ds223-microp
>>> + - synology,ds223j-microp
>>> + - synology,ds1823xsp-microp
>>> + - synology,rs822p-microp
>>> + - synology,rs1221p-microp
>>> + - synology,rs1221rpp-microp
>>> + - synology,ds925p-microp
>>> + - synology,ds1525p-microp
>>> + - synology,ds1825p-microp
>>
>> Previous comment is not resolved. For example you stated that ds723p is
>> compatible with ds725p, so this should be expressed.
> Using this expression?
>
> properties:
> compatible:
> oneOf:
> - enum:
> - synology,ds923p-microp
> - synology,ds1522p-microp
> - enum:
> - synology,ds918p-microp
> - synology,ds415p-microp
> - const: synology,ds214play-microp
> ...
> ?
> If so shall there each be a description?

No, you changed nothing. You need fallbacks, please read example-schema
or DTS101 slides.

Best regards,
Krzysztof