Re: [PATCH v2 3/3] staging: rtl8723bs: remove unnecessary else after return in sdio_halinit.c

[Luka Gejak]

On April 12, 2026 6:06:00 PM GMT+02:00, Luka Gejak <lukagejak5@xxxxxxxxx> wrote:
>LGTM.
>Reviewed-by: Luka Gejak <luka.gejak@xxxxxxxxx>
>
>On April 12, 2026 5:06:33 PM GMT+02:00, Josh Hesketh <josh.hesketh@xxxxxxxxx> wrote:
>>Remove else branch following a conditional return statement
>>
>>Signed-off-by: Josh Hesketh <josh.hesketh@xxxxxxxxx>
>>---
>>v2:
>> - Rebased on staging-next
>> - Split from original patch 1/2
>> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>>diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>>index 4a4f6b03253a..ed82860ae9b6 100644
>>--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>>+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
>>@@ -641,11 +641,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
>> 		padapter->bFWReady = false;
>> 		pHalData->fw_ractrl = false;
>> 		return ret;
>>-	} else {
>>-		padapter->bFWReady = true;
>>-		pHalData->fw_ractrl = true;
>> 	}
>> 
>>+	padapter->bFWReady = true;
>>+	pHalData->fw_ractrl = true;
>>+
>> 	rtl8723b_InitializeFirmwareVars(padapter);
>> 
>> 	if (pwrctrlpriv->reg_rfoff)

EDIT: Sent from wrong email address(I hate thunderbird and I'm not 
near my laptop).
LGTM.
Reviewed-by: Luka Gejak <luka.gejak@xxxxxxxxx>