Re: [PATCH 14/19] drm/panel: jadard-jd9365da-h3: support Waveshare DSI panels

[Dmitry Baryshkov]

On Thu, 9 Apr 2026 at 11:50, Linus Walleij <linusw@xxxxxxxxxx> wrote:
>
> On Thu, Apr 9, 2026 at 2:49 AM Dmitry Baryshkov
> <dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:
>
> > > But there is also one more thing, this looks like a big "jam table"
> > > with just register+value tuples, so construct something like:
> > >
> > > struct jadard_jam_tbl_entry {
> > >         u8 reg;
> > >         u8 val;
> > > };
> > >
> > > static const struct jadard_jam_tbl_entry jd_3_4_c_init_jam[] = {
> > >         {0x00, 0x00}, {0x01, 0x41}, ...};
> > >
> > > (Ideas taken from drivers/net/dsa/realtek/rtl8366rb.c, take a look
> > > for code and all, you get the picture.)
> >
> > Few months ago the code was moved exactly in the opposite direction. We
> > added all _multi() functions and made shure that the code is as
> > efficient as the register tables. On the other hand, having it as a code
> > allows better control. E.g. handling 2/4 lane case would require extra
> > hacks to the register tables, while the code handles that without extra
> > hacks and without loosing effectiveness.
>
> OK then sorry for the fuzz!

No worries, it's fine to explain it (and also sorry for me not being
able to answer your other questions).

> Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>


-- 
With best wishes
Dmitry