RE: [PATCH v3 2/2] dt-bindings: leds: Document LTC3208 Multidisplay LED Driver

[Roleda, Jan carlo]

Hello Krzysztof,

Thank you again for the review. 

For clarification,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Tuesday, April 7, 2026 2:58 PM
> To: Roleda, Jan carlo <Jancarlo.Roleda@xxxxxxxxxx>
> Cc: Lee Jones <lee@xxxxxxxxxx>; Pavel Machek <pavel@xxxxxxxxxx>; Rob
> Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor
> Dooley <conor+dt@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-
> leds@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 2/2] dt-bindings: leds: Document LTC3208 Multidisplay
> LED Driver
> 
> [External]
> 
> On Mon, Apr 06, 2026 at 03:17:06PM +0800, Jan Carlo Roleda wrote:
> > Add Documentation for LTC3208 Multidisplay LED Driver.
> >
> > Signed-off-by: Jan Carlo Roleda <jancarlo.roleda@xxxxxxxxxx>
> > ---
> 
> Still incorrect order.
> 
> ...
> 
> > +
> > +      led-controller@1b {
> > +        compatible = "adi,ltc3208";
> > +        reg = <0x1b>;
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        adi,disable-camhl-pin;
> > +        adi,cfg-enrgbs-pin;
> > +        adi,disable-rgb-aux4-dropout;
> > +
> > +        led@0 {
> > +          reg = <0>;
> 
> I still expect this to be complete, so at least function and color.
> 
> Best regards,
> Krzysztof

Are you referring here to keep the led@0-6,
but instead of only the reg I should include other LED properties (i.e. function and color)?
If so, I will add them as such in the next patch.

Do let me know if this is correct.

Regards,
Carlo