Re: [PATCH v1] tpm: restore timeout for key creation commands

From: Zhang, Baoli

Date: Sun Apr 12 2026 - 21:34:05 EST

On 4/10/2026 2:49 PM, Paul Menzel wrote:

Dear Baoli,

Thank you for your patch. Some formalities:

Am 10.04.26 um 03:49 schrieb Baoli.Zhang:

After the per-command duration map was introduced, TPM2 key creation
commands (`CREATE_PRIMARY`, `CREATE`, `CREATE_LOADED`) were limited to
30 seconds.

On some platforms this is not sufficient and key creation can time out.
Commit 207696b17f38 ("tpm: use a map for tpm2_calc_ordinal_duration()")
inadvertently reduced these command timeouts from 300 seconds to 30
seconds. Restore them to 300 seconds to avoid spurious failures.

Please document such a platform.

Thanks for your comments, I will add the platform after the internal alignment.

Fixes: 207696b17f38 ("tpm: use a map for tpm2_calc_ordinal_duration()")

Signed-off-by: Baoli.Zhang <baoli.zhang@xxxxxxxxxxxxxxx>

It’d be great if you remove the dot from your name:

git config --global user.name "Baoli Zhang"

Yes, will remove it in v2.

Co-developed-by: lili.li <lili.li@xxxxxxxxx>

Same here. Maybe spell it Lili Li?

git commit --amend --author="BaoliZhang <baoli.zhang@xxxxxxxxxxxxxxx>" -s

Yes, her name is Lili Li. Will also remove dot from her name.

---
drivers/char/tpm/tpm2-cmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
index 3a77be7ebf4aa..430022f695f24 100644
--- a/drivers/char/tpm/tpm2-cmd.c
+++ b/drivers/char/tpm/tpm2-cmd.c
@@ -71,9 +71,9 @@ static const struct {
      {TPM2_CC_HIERARCHY_CHANGE_AUTH, 2000},
      {TPM2_CC_GET_CAPABILITY, 750},
      {TPM2_CC_NV_READ, 2000},
-    {TPM2_CC_CREATE_PRIMARY, 30000},
-    {TPM2_CC_CREATE, 30000},
-    {TPM2_CC_CREATE_LOADED, 30000},
+    {TPM2_CC_CREATE_PRIMARY, 300000},
+    {TPM2_CC_CREATE, 300000},
+    {TPM2_CC_CREATE_LOADED, 300000},
};
/**