Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants

[Dan Carpenter]

On Mon, Apr 13, 2026 at 10:51:16AM +0530, Adith Joshua wrote:
> Hi Dan, Luka,
> 
> Thanks for the review.
> 
> Made some careless errors there... sorry about that
> 
> Looking at it again, I see that the BCNTCFG field mapping in my patch is
> wrong (I swapped AIFS and CW in the naming). The TBTT_PROHIBIT suffix was
> also an assumption based on a vague comment, which I shouldn’t have relied
> on.
> 
> I was looking at:
> https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/drivers/staging/rtl8188eu/include/rtl8188e_spec.h#296
> 
> and also cross-referencing with rtw88:
> drivers/net/wireless/realtek/rtw88/reg.h
> 
> And no, this wasn’t AI generated 🙂(I know the choice of emoji could be
> better)
> 
> I'll send a v2 with these corrections.
> 

Please don't bother.

This explanation is again far too vague to be checked.  I would
prefer to leave it as-is until we are more sure that the information
is correct.  Misleading documentation is worse than having none.

regards,
dan carpenter