Re: [RFC PATCH 1/2] drm: Introduce drm_panel_prepare_for_mode callback

[Neil Armstrong]

On 4/13/26 03:05, Dmitry Baryshkov wrote:
> On Sun, Apr 12, 2026 at 08:00:44AM -0300, Val Packett wrote:
> > Modern OLED panels often need to vary their prepare commands based on the
> > mode being set (resolution and refresh rate). Introduce a new variant of
> > the drm_panel_prepare callback that passes the chosen mode as an argument
> > to allow for this.
> >
> > Signed-off-by: Val Packett <val@xxxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/bridge/panel.c |  8 ++++++--
> >   drivers/gpu/drm/drm_panel.c    | 15 +++++++++++++--
> >   include/drm/drm_panel.h        | 12 ++++++++++++
> >   3 files changed, 31 insertions(+), 4 deletions(-)
>
> A (somewhat) better approach would be to let add .atomic_foo callbacks,
> which would receive drm_atomic_state instance. See  the discussion
> around [1].
>
> [1] https://lore.kernel.org/dri-devel/nfc6ih43gjpi5u67fpkkxgwwygv53grdldq7tfp5iiukrkiy2u@53fsrtezzkyt/

I agree, the plan to add a new atomic ops if much better.

Neil