Re: [PATCH v2 1/1] vfio/nvgrace-gpu: Add Blackwell-Next GPU readiness check via CXL DVSEC

[Ankit Agrawal]

>> +static inline unsigned long nvgrace_gpu_cxl_mem_active_timeout_ms(u8
>> timeout)
>> +{
>> +     return 1000UL << (2 * min_t(u8, timeout, 4));
>> +}
>
> this is local to this file and simple. it's ok to remove the 'nvgrace_gpu_'
> prefix so the caller line is shorter. Later it may be moved to cxl header
> file if other callers exist.

Ack, will fix.

>> +{
>> +     struct pci_dev *pdev = nvdev->core_device.pdev;
>> +     int pcie_dvsec = nvdev->cxl_dvsec;
>
> s/pcie_dvsec/cxl_dvsec/

Ack.

>> 
>> -     ret = nvgrace_gpu_wait_device_ready(io);
>> +     ret = nvgrace_gpu_wait_device_ready(nvdev, io);
>> 
>>        pci_iounmap(pdev, io);
>
> bar0 mapping is not required in the new method.

True, will address that.