Re: [PATCH] dt-bindings: iio: light: Add PixArt PAJ7620 gesture sensor
From: Krzysztof Kozlowski
Date: Mon Apr 13 2026 - 04:22:15 EST
On Sun, Apr 12, 2026 at 08:02:55PM -0400, Harpreet Saini wrote:
> Signed-off-by: Harpreet Saini <sainiharpreet29@xxxxxxxxx>
> ---
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
> This is part 1 of a 2-patch series proposing a driver for the PixArt
> PAJ7620 gesture sensor. This patch adds the Device Tree bindings and
> registers the "pixart" vendor prefix. The driver patch will follow in
> a succeeding branch.
No, we do not want bindings without users. The driver patch must follow
here. We also do not work with branches, but patches on mailing list.
Please read submitting patches documents - both, so also the one in DT
binding dir.
I finished the review here.
Best regards,
Krzysztof