Re: [PATCH 06/53] selftests/mm: rename hugepage-* tests to hugetlb-*

[Mike Rapoport]

Hi,

On Thu, Apr 09, 2026 at 03:03:51PM +0530, Donet Tom wrote:
> Hi Mike
> 
> On 4/6/26 7:46 PM, Mike Rapoport wrote:
> 
>     From: "Mike Rapoport (Microsoft)" <rppt@xxxxxxxxxx>
> 
>     hugepage could mean both THP and HugeTLB these days.
> 
>     Rename hugepage-* tests for HugeTLB to hugetlb-* to avoid confusion.
> 
>     Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
>     ---
>      tools/testing/selftests/mm/.gitignore                     | 4 ++++
>      tools/testing/selftests/mm/Makefile                       | 8 ++++----
>      tools/testing/selftests/mm/hugetlb-madvise.c              | 2 +-
>      .../selftests/mm/{hugepage-mmap.c => hugetlb-mmap.c}      | 2 +-
>      .../selftests/mm/{hugepage-mremap.c => hugetlb-mremap.c}  | 2 +-
>      .../selftests/mm/{hugepage-shm.c => hugetlb-shm.c}        | 2 +-
>      .../mm/{hugepage-vmemmap.c => hugetlb-vmemmap.c}          | 0
>      tools/testing/selftests/mm/run_vmtests.sh                 | 8 ++++----
>      8 files changed, 16 insertions(+), 12 deletions(-)
>      rename tools/testing/selftests/mm/{hugepage-mmap.c => hugetlb-mmap.c} (99%)
>      rename tools/testing/selftests/mm/{hugepage-mremap.c => hugetlb-mremap.c} (99%)
>      rename tools/testing/selftests/mm/{hugepage-shm.c => hugetlb-shm.c} (99%)
>      rename tools/testing/selftests/mm/{hugepage-vmemmap.c => hugetlb-vmemmap.c} (100%)
> 
>     diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
>     index b0c30c5ee9e3..9ccd9e1447e6 100644
>     --- a/tools/testing/selftests/mm/.gitignore
>     +++ b/tools/testing/selftests/mm/.gitignore
>     @@ -4,6 +4,10 @@ hugepage-mmap
>      hugepage-mremap
>      hugepage-shm
>      hugepage-vmemmap
> 
> Should we consider removing this from .gitignore? Otherwise, this looks good to
> me.

A while ago Linus objected to removing selftest binaries from .gitignore,
can't find lore link right now.
 
> Reviewed by: Donet Tom <donettom@xxxxxxxxxxxxx>

Thanks!
 
> -Donet

-- 
Sincerely yours,
Mike.