Re: [PATCH v2 2/3] mm/memory-failure: add panic_on_unrecoverable_memory_failure sysctl

[Breno Leitao]

On Mon, Apr 13, 2026 at 11:42:19AM +0800, Miaohe Lin wrote:
> On 2026/4/10 22:17, Breno Leitao wrote:
> > On Tue, Apr 07, 2026 at 10:57:36AM +0800, Miaohe Lin wrote:
> >> On 2026/3/31 19:00, Breno Leitao wrote:
> > +{
> > +	return sysctl_panic_on_unrecoverable_mf &&
> > +	       result == MF_IGNORED &&
> > +	       (type == MF_MSG_KERNEL ||
> > +		type == MF_MSG_KERNEL_HIGH_ORDER ||
> > +		type == MF_MSG_UNKNOWN);
> > +}
> > +
> >  /*
> >   * "Dirty/Clean" indication is not 100% accurate due to the possibility of
> >   * setting PG_dirty outside page lock. See also comment above set_page_dirty().
> > @@ -1298,6 +1319,9 @@ static int action_result(unsigned long pfn, enum mf_action_page_type type,
> >  	pr_err("%#lx: recovery action for %s: %s\n",
> >  		pfn, action_page_types[type], action_name[result]);
> >
> > +	if (is_unrecoverable_memory_failure(type, result))
>
> Would it be better to name it as panic_on_unrecoverable_mf() or something like it?
> This function determines whether panic on the specified memory error.

Acknowledged. I'll rename the function to panic_on_unrecoverable_mf() in the
next version.

After extensive testing, I'm considering adding a boot-time configuration
parameter for this feature, similar to BOOTPARAM_WQ_STALL_PANIC,
BOOTPARAM_SOFTLOCKUP_PANIC, BOOTPARAM_HARDLOCKUP_PANIC, and
BOOTPARAM_HUNG_TASK_PANIC. This would make the panic behavior available
from early boot without requiring runtime sysctl configuration, ensuring
the system crashes on unrecoverable ECC errors rather than ignoring
them.

I'll prepare and send the updated version shortly.

Thanks for your feedback,
--breno