Re: [PATCH] f2fs: do not support mmap write for large folio

[David Hildenbrand (Arm)]

On 4/8/26 20:08, Jaegeuk Kim wrote:
> On 04/08, David Hildenbrand (Arm) wrote:
>> On 4/8/26 07:03, Christoph Hellwig wrote:
>>>
>>> In general spelling such basic out in the commit log, and even comments
>>> is really helpful.  I'm curious how this works, though - by the time
>>> you read a large folio you don't know if it will ever be written to.
>>
>> Why are only large folios supported for read?
>>
>> Where is that allocation logic and how can that path even be triggered?
>>
>> Also, usually we check for large folios by testing the actual folio, not
>> whether the mapping supports them?
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v7.0-rc7&id=05e65c14ea59a401cec4284e9d612f9d5dc1b3f8
> 
> Currently I think it's simple to check the mapping in our case.

Thanks for the pointer.

So you are adding code for something that is impossible to be reached.

Reading the other discussions, I agree that this should be flagged
clearer as an assertion, and not a fix.

I'll let maintainers decide whether that is a assertion we should add :)

-- 
Cheers,

David