Re: [PATCH v10 12/21] gpu: nova-core: mm: Add unified page table entry wrapper enums
From: Joel Fernandes
Date: Mon Apr 13 2026 - 16:14:46 EST
Hi Danilo,
On 4/9/2026 7:00 AM, Danilo Krummrich wrote:
> On Thu Apr 9, 2026 at 12:33 PM CEST, Joel Fernandes wrote:
>> Since it is 3 against 1 here, I rest my case :-).
>
> That's not how I'd view it. :)
>
> Anyways, in case I'm included in "3", that's not my position. My point was to
> ensure we keep discussing advantages and disadvantages on their merits, as I
> think you both have good points.
Heh, yes I actually *did not* include you in the 3 since you sounded to be open
to both. ;-)
>
>> I am still in disagreement since I do not see much benefit (that is why I said
>> pointless above).
>
> That is fair -- in this case please explain why the advantages pointed out by
> others are not worth it, propose something that picks up the best of both
> worlds, etc.
>
> You can also turn it around and ask people whether they can tweak their counter
> proposal to get rid of specific parts you dislike for a reason.
>
> IOW, keep the ball rolling, so we can come up with the best possible solution.
Good advice, thanks! I will try to come up with something that is acceptable to
everyone and we can further debate pros/cons on v11.
There are some merits on the alternative proposal from Eliot/Alex that I'd like
to explore while seeing if I can keep some of the merits in mine as well.
thanks,
--
Joel Fernandes