Re: [PATCH v2 1/6] ASoC: renesas: fsi: Add shared SPU clock support

[Kuninori Morimoto]

Hi

> Add SPU clock pointer, reference counter, and locking in fsi_master for
> shared FSIA/FSIB usage, and initialize them in fsi_probe().
> 
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---
(snip)
> diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c
> index 1491c2f2cc96..196ec7bac33d 100644
> --- a/sound/soc/renesas/fsi.c
> +++ b/sound/soc/renesas/fsi.c
> @@ -292,8 +292,11 @@ struct fsi_master {
>  	void __iomem *base;
>  	struct fsi_priv fsia;
>  	struct fsi_priv fsib;
> +	struct clk *clk_spu;
>  	const struct fsi_core *core;
> +	int spu_count;
>  	spinlock_t lock;
> +	struct mutex clk_lock;
>  };

You added clk_spu in this patch, but not touched.
When I checked whole patch-set, you initialize it at [4/6], but [2/6] is
using it. Maybe it works, but is strange.

The total patch orders are opposite, I think.
I think it can be...

As prepare

	- Fix trigger stop ordering
	- move fsi_clk_init()
	  - this just moves the function, no change

As adding new feature

	- remains

Thank you for your help !!

Best regards
---
Kuninori Morimoto