Re: Re: [PATCH v3 1/2] dt-bindings: pwm: dwc: add reset optional

[Xuyang Dong]

> > 
> > The DesignWare PWM controller provides separate reset signals for each
> 
> So one controller has signals. Plural, right? Then why do you define
> only one reset signal?
> 

Hi Krzysztof,

There are two reset signals matching the two clocks, so maxItems is set to 2.

> > clock domain, as specified in the hardware documentation. Without
> > asserting and deasserting these resets during probe, PWM outputs may
> > remain in an undefined state after system reboot.
> > 
> > To address this, the driver now supports an optional 'resets' property.
> 
> This is binding change, not driver.
> 
> > A full reset is performed only when no PWM channel is enabled, as
> > determined by reading the enable bit in each channel's control register.
> 
> Do you describe hardware or driver behavior? This is not a change about
> driver. Describe the hardware here - what is expected with that reset.
> 
> > This allows safe coexistence with bootloaders that have already
> > configured active PWM channels.
> 

The improvement commit message for the next version will be revised 
as follows:

The DesignWare PWM includes separate reset signals dedicated to each clock 
domain:
The presetn signal resets logic in pclk domain.
The timer_N_resetn signal resets logic in the timer_N_clk domain.
The resets are active-low.

In the next version, we will address the changes as described above.

Best regards,
Xuyang Dong