Re: [PATCH v10] staging: rtl8723bs: remove commented-out code

[Dan Carpenter]

On Tue, Apr 14, 2026 at 12:05:34PM +0530, Aadarsh Mandal wrote:
> Remove code that is not used anywhere in driver.
> 
> Signed-off-by: Aadarsh Mandal <aadarshmandal9354@xxxxxxxxx>
> ---
> v10:
>  - Change in commit style.

Heh.

We really do want to know what changed between versions but this is
too vague to be useful.  The problem is that we are very lazy and
forgetful and we can't remember or be bothered to look it up.  If
we have a note, we easily check if you added a Signed-off-by line
we asked for or whatever.

So this should have been "The notes under the --- cut off line were
misnumbered.  Fix that."  It's not really fixed.  :P  But whatever
at this point I'm ready to just merge this.

Reviewed-by: Dan Carpenter <error27@xxxxxxxxx>

> v9:
>  - Change in commit style.

This should have been "Don't do unrelated white space changes".

> v8:
>  - Restore the formatting of non-commented code.

This one was probably intended to be the note for v9.  In v7 what
we complained about was that you said "no change" and we wondered
why you were resending patches with no change.  This message should
have been "Add better notes under the --- cut off line".

> v7:
>  - Change in commit style.

This one was "Add a Signed-off-by line."

regards,
dan carpenter