Re: [PATCH v4 08/13] mfd: sec: resolve PMIC revision in S2MU005

[Kaustabh Chakraborty]

On 2026-04-14 12:03 +05:30, Kaustabh Chakraborty wrote:
> In devices other than S2MPG1X, the revision can be retrieved from the
> first register of the PMIC regmap. In S2MU005 however, the location is
> in offset 0x73. Introduce a switch-case block to allow selecting the
> REG_ID register.
>
> S2MU005 also has a field mask for the revision. Apply it using
> FIELD_GET() and get the extracted value.
>
> Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
> ---
>  drivers/mfd/sec-common.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c
> index 883e6d0aa3f06..43215605191e4 100644
> --- a/drivers/mfd/sec-common.c
> +++ b/drivers/mfd/sec-common.c
> @@ -16,6 +16,7 @@
>  #include <linux/mfd/samsung/irq.h>
>  #include <linux/mfd/samsung/s2mps11.h>
>  #include <linux/mfd/samsung/s2mps13.h>
> +#include <linux/mfd/samsung/s2mu005.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/pm.h>
> @@ -119,20 +120,27 @@ static const struct mfd_cell s2mu005_devs[] = {
>  
>  static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic)
>  {
> -	unsigned int val;
> +	unsigned int reg, mask, val;
>  
> -	/* For s2mpg1x, the revision is in a different regmap */
>  	switch (sec_pmic->device_type) {
>  	case S2MPG10:
>  	case S2MPG11:
> +		/* For s2mpg1x, the revision is in a different regmap */
>  		return;
> -	default:
> +	case S2MU005:
> +		reg = S2MU005_REG_ID;
> +		mask = S2MU005_ID_MASK;
>  		break;
> +	default:
> +		/* For other device types, REG_ID is always the first register. */
> +		reg = S2MPS11_REG_ID;
> +		mask = ~0;
>  	}
>  
> -	/* For each device type, the REG_ID is always the first register */
> -	if (!regmap_read(sec_pmic->regmap_pmic, S2MPS11_REG_ID, &val))
> +	if (!regmap_read(sec_pmic->regmap_pmic, reg, &val)) {
> +		val = FIELD_GET(S2MU005_ID_MASK, val);

Bug here! FIELD_GET(mask, val) should've been used.

>  		dev_dbg(sec_pmic->dev, "Revision: 0x%x\n", val);
> +	}
>  }
>  
>  static void sec_pmic_configure(struct sec_pmic_dev *sec_pmic)