Re: [PATCH v4 3/9] coresight: etm4x: fix leaked trace id

[Jie Gan]

On 4/13/2026 10:19 PM, Yeoreum Yun wrote:
> If etm4_enable_sysfs() fails in cscfg_csdev_enable_active_config(),
> the trace ID may be leaked because it is not released.
>
> To address this, call etm4_release_trace_id() when etm4_enable_sysfs()
> fails in cscfg_csdev_enable_active_config().

LGTM.

Reviewed-by: Jie Gan <jie.gan@xxxxxxxxxxxxxxxx>

> Signed-off-by: Yeoreum Yun <yeoreum.yun@xxxxxxx>
> ---
>   drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> index 8ebfd3924143..1bc9f13e33f7 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> @@ -918,8 +918,10 @@ static int etm4_enable_sysfs(struct coresight_device *csdev, struct coresight_pa
>   	cscfg_config_sysfs_get_active_cfg(&cfg_hash, &preset);
>   	if (cfg_hash) {
>   		ret = cscfg_csdev_enable_active_config(csdev, cfg_hash, preset);
> -		if (ret)
> +		if (ret) {
> +			etm4_release_trace_id(drvdata);
>   			return ret;
> +		}
>   	}
>   
>   	raw_spin_lock(&drvdata->spinlock);