Re: [PATCH v4 2/5] media: iris: Add hardware power on/off ops for X1P42100
From: Wangao Wang
Date: Tue Apr 14 2026 - 04:35:35 EST
On 2026/4/8 18:41, Krzysztof Kozlowski wrote:
On 08/04/2026 11:16, Wangao Wang wrote:
On 2026/4/2 15:08, Krzysztof Kozlowski wrote:
The original patch was to add the IRIS_BSE_HW_CLK operation into the
Why no IRIS_HW_AHB_CLK in power on sequence?
So if you rewrite the code that you have list of clocks for hw power on
(IRIS_HW_CLK + IRIS_HW_AHB_CLK for all variants, +IRIS_BSE_HW_CLK on
this variant) you could have just one function for all of them and
devices will be fully compatible.
No?
common API, but Dmitry requested to separate Purwa's implementation out
independently.
So you don't know why you are doing things? I don't understand what sort
of argument is that.
You are duplicating code, while all this is simply the same logic -
three clocks which need to be enabled.
Best regards,
Krzysztof
Hi Dmitry,
I think this can be moved into the common code, so that any future VPU3-related changes will also be applied to purwa. What do you think? If that works, I’ll update it in the next version.
--
Best Regards,
Wangao