Re: [PATCH v1 2/3] pinctrl: qcom: lpass-lpi: Fix GPIO register access helper return types
From: Konrad Dybcio
Date: Tue Apr 14 2026 - 04:39:46 EST
On 4/13/26 2:22 PM, Ajay Kumar Nandam wrote:
> The LPI GPIO register access helpers previously returned the value from
> ioread32(), even though their return type was int. This mixes data
> return with status and is inconsistent with common kernel helper
> conventions.
>
> Rework lpi_gpio_read() and lpi_gpio_write() to return an int status and
> use output parameters to pass register values. Update all callers to
> match the new helper interface.
lpi_gpio_read/write() can never fail, let's just make _read() return
a u32 and _write() a void
Konrad