Re: [PATCH v3 1/2] iio: frequency: ad9832: remove kernel.h proxy header.

From: Andy Shevchenko

Date: Tue Apr 14 2026 - 05:38:15 EST


On Sat, Apr 11, 2026 at 02:35:11PM +0200, Joshua Crofts wrote:
> Remove kernel.h proxy header and add bitops.h for
> better dependency control and code clarity.

...

> #include <asm/div64.h>

While at it, you can move asm/* to go after generic linux/* ones as asm is more
custom than linux.

> #include <linux/bitfield.h>
> -#include <linux/bits.h>
> +#include <linux/bitops.h>
> #include <linux/clk.h>

> #include <linux/device.h>

What about this one? Is it used?

Many drivers just need dev_printk.h + device/devres.h. Some indeed require
device.h. Please, double check.

> #include <linux/err.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/regulator/consumer.h>
> #include <linux/slab.h>

--
With Best Regards,
Andy Shevchenko