Re: [PATCH 1/3] iio: frequency: ad9834: clean up includes

[Andy Shevchenko]

On Tue, Apr 14, 2026 at 09:12:48AM +0000, Joshua Crofts wrote:
> Clean up includes by removing proxy kernel.h header,
> add bitops.h header and order includes for better
> readability.

...

> +#include <asm/div64.h>

This should go after generic linux/*. In other words, it was originally placed
correctly.

> +#include <linux/bitops.h>
>  #include <linux/clk.h>
> -#include <linux/interrupt.h>
> -#include <linux/workqueue.h>

>  #include <linux/device.h>

Also check for usage of this one.

> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/sysfs.h>
> -#include <linux/list.h>
> -#include <linux/spi/spi.h>
> -#include <linux/regulator/consumer.h>
>  #include <linux/err.h>
> +#include <linux/interrupt.h>
> +#include <linux/list.h>
>  #include <linux/module.h>
> -#include <asm/div64.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/slab.h>
> +#include <linux/spi/spi.h>
> +#include <linux/sysfs.h>
> +#include <linux/workqueue.h>

-- 
With Best Regards,
Andy Shevchenko